Disable wat feature from wasmer and wasmtime
#2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of only running the tests if the feature is enabled. Also enable the `wat` feature in preparation to remove the `sys-default` feature.
It doesn't seem to be needed.
Disable the default features on `wasmer-compiler-singlepass`.
Only enable the ones that are needed.
jvff
force-pushed
the
disable-wat-features
branch
from
b3a5fb1
to
28edac0
Compare
Twey
reviewed
Oct 8, 2024
| @@ -404,7 +404,7 @@ impl<'bytecode> Sanitizer<'bytecode> { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(all(test, with_wasmer))] | |||
| #[cfg(test)] | |||
There was a problem hiding this comment.
Now we have to :/ Because otherwise we can't enable the wat feature only for tests :(
There was a problem hiding this comment.
:(
Relevant discussion: rust-lang/cargo#1596
Twey
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We've recently had dependency version conflicts for
watbetweenwasmerandwasmtime, which required releasing a new version of ourlinera-wasmerwork every time an update forwasmtimewas needed (#2427, #2530). That dependency onwatisn't actually needed on either runtime, except for a couple of tests.Proposal
Disable the
watfeatures and additional features fromwasmerandwasmtime.Because
dev-dependenciescan't have optional dependencies, nowlinera-executiontests requirewasmerso that it can enable thewatfeature.Test Plan
CI should catch regressions, since this just changes dependencies.
Release Plan
Links